Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProxyConfig promote command idempotent #174

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

miguelsorianod
Copy link
Contributor

Related to issue #173.

This PR shows a warning instead of returning an exit code different than 0 when a Staging ProxyConfig environment version has already been promoted to the Production environment.

The behavior now is:

  • If ProxyConfig staging for a service does not exist (has never been updated) an error is raised
  • If ProxyConfig production for a service does not exist, and promote is executed, the proxyconfiguration is promoted (it means the staging proxyconfiguration had never been promoted)
  • If ProxyConfig staging and production for a service are the same a warning is shown and an exit code 0 is returned (normal exit)
  • If ProxyConfig staging and production for a service are different the staging configuration is promoted to production

The output text shown in the CLI has been modified in both positive and negative outcomes to be a little more descriptive.

cc @nmasse-itix

@miguelsorianod miguelsorianod requested a review from eguzki June 18, 2019 15:28
@eguzki eguzki merged commit bbd9ecf into master Jun 19, 2019
@eguzki eguzki deleted the proxy-config-promote-idempotent branch June 19, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants