Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openapi CRD #496

Merged
merged 32 commits into from
Oct 30, 2020
Merged

Openapi CRD #496

merged 32 commits into from
Oct 30, 2020

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Oct 19, 2020 •
edited
Loading

CRD (and controller) holding OAS3 reference (configmap or URL) as source of truth for 3scale Product and 3scale Backend configuration.

TODO:

  • Doc
  • Unittests
  • Custom private base URL
  • Openapi Status with relevant info
  • Prefix matching option
  • private api security options
  • OAS from URL

Fixes #119

@eguzki eguzki requested a review from miguelsorianod October 19, 2020 16:17
@eguzki eguzki force-pushed the openapi-controller branch 2 times, most recently from 286cd7e to e45cabc Compare October 21, 2020 17:20
@eguzki
Copy link
Member Author

eguzki commented Oct 21, 2020 •
edited
Loading

Ready for initial review. @miguelsorianod

Missing only small things and unittests

@eguzki eguzki force-pushed the openapi-controller branch 4 times, most recently from a88edf6 to 4e8e05b Compare October 24, 2020 16:26
eguzki added 19 commits October 27, 2020 17:05
@eguzki
openapis.capabilities.3scale.net API and controller scaffolding
9e07b82
@eguzki
openapi controller implementation
ffda249
@eguzki
openapi controller: openapi from configmap
e12c369
@eguzki
backend_types.go: little fix
88b75d8
@eguzki
little fix in openapi CRD
e090898
@eguzki
little fix in base_reconciler
9cf0b4f
@eguzki
openapi controller: backend reconciler
9b17a18
@eguzki
openapi controller: product reconciler
73b78a4
@eguzki
openapi controller: openapi from URL
75821bd
@eguzki
template update: no relevant change, only newlines
7b97d7c
@eguzki
openapi controller: custom private base URL
cec57ab
@eguzki
openapi controller: prefix matching option
d0c64a0
@eguzki
openapi controller: private api security
97cafe7
@eguzki
update 3scale-operator-master.v0.0.0.clusterserviceversion.yaml
5c6f834
@eguzki
openapi controller: status shows managed resource references
6001a60
@eguzki
openapi CRD doc
f66d5da
@eguzki
openapi CRD: remove unused property
9929ea4
@eguzki
openapi controller: implement ready condition type of status conditions
45bb6c7
@eguzki
openapi CRD tests
d95be0c
@eguzki eguzki force-pushed the openapi-controller branch from 8fa96cb to d95be0c Compare October 27, 2020 16:05
@eguzki eguzki marked this pull request as ready for review October 27, 2020 16:05
@eguzki
Copy link
Member Author

eguzki commented Oct 27, 2020

Unittests left as tech debt as coming soon upgrade of the operator-sdk version would require lots of refactors

miguelsorianod
miguelsorianod suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some feedback and some questions to better understand the motivation of some implementation.

Looks good 👍

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Oct 29, 2020
miguelsorianod
miguelsorianod approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

There's some comments but they are not blocking to me so up to you if you want to change something or not

@codeclimate
Copy link

codeclimate bot commented Oct 30, 2020

Code Climate has analyzed commit 46b1b81 and detected 54 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 12
Duplication 13
Style 29

View more on Code Climate.

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Oct 30, 2020
@miguelsorianod miguelsorianod merged commit e72f2c7 into master Oct 30, 2020
@miguelsorianod miguelsorianod deleted the openapi-controller branch October 30, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees

@miguelsorianod miguelsorianod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI Support & Discovery
2 participants
@eguzki @miguelsorianod