-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/dynamic-watches #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/feature
Categorizes issue or PR as related to a new feature.
kind/documentation
Categorizes issue or PR as related to documentation.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
labels
Jan 11, 2024
3scale-robot
added
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
size/M
Requires about a day to complete the PR or the issue.
and removed
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
labels
Jan 11, 2024
raelga
approved these changes
Jan 11, 2024
LGTM label has been added. Git tree hash: de1539935ee9b9b11037e41ea8ce75d9715df26a
|
slopezz
approved these changes
Jan 11, 2024
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/documentation
Categorizes issue or PR as related to documentation.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/M
Requires about a day to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to watch the controller owned resources automatically and dynamically once the controller is already started.
The idea is that the type tracker, that was already implemented and was being used for the resource pruner, now also sets up a new watch each time it sees a new resource type (GVK) being managed by the controller.
Pros:
Cons:
I have also added some missing documentation and fixed several misspells.
/kind feature
/kind documentation
/assign
/priority important-soon