Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade to latest rules_boost" #71

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

rjhuijsman
Copy link
Contributor

Reverts #70

Alas, that change causes a failure when pulled reboot-dev/respect:

$ bazel build //object_store:library
INFO: Invocation ID: 1c4294c4-b31d-468f-b128-9dcdea56faaf
ERROR: /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/com_github_reboot_dev_zlib/BUILD.bazel:2:6: no such target '@net_zlib_zlib//:zlib': target 'zlib' not declared in package '' defined by /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/net_zlib_zlib/BUILD.bazel and referenced by '@com_github_reboot_dev_zlib//:z'
INFO: Repository boost instantiated at:
  /workspaces/respect/WORKSPACE.bazel:62:5: in <toplevel>
  /workspaces/respect/bazel/deps.bzl:46:19: in deps
  /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/com_github_3rdparty_eventuals/bazel/deps.bzl:103:15: in deps
  /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/com_github_3rdparty_stout/bazel/deps.bzl:14:15: in deps
  /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/com_github_nelhage_rules_boost/boost/boost.bzl:156:10: in boost_deps
  /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/bazel_tools/tools/build_defs/repo/utils.bzl:233:18: in maybe
Repository rule http_archive defined at:
  /home/vscode/.cache/bazel/_bazel_vscode/e9b5149ef40c40531841044f5a70254d/external/bazel_tools/tools/build_defs/repo/http.bzl:355:31: in <toplevel>
ERROR: Analysis of target '//object_store:library' failed; build aborted: 
INFO: Elapsed time: 2.087s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
    Fetching https://github.com/boostorg/boost/releases/download/boost-1.84.0/boost-1.84.0.tar.gz

It looks like we'll need to debug the new zlib issue (some conflict?), but in the meantime let's get back to a working state.

Copy link

aviator-app bot commented Jan 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

aviator-app bot commented Jan 15, 2024

Branch up-to-date, waiting for checks.

@aviator-app aviator-app bot merged commit 798745d into main Jan 15, 2024
5 checks passed
@aviator-app aviator-app bot deleted the revert-70-rjh.modern-boost branch January 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants