-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fix #597
Build fix #597
Conversation
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time. |
3ad34ee
to
ea41837
Compare
a9d0d96
to
1763b0d
Compare
Since we are using codespaces for develop, all docker (dazel) things can be removed, as well as run build using github runner config, but with config=asan off |
378646c
to
437423d
Compare
3455888
to
5af723f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some more unexpected-to-me changes have popped up, so I'd like some clarification on those before I approve.
For posterity, it would be good to record the "why" of this PR in the PR description:
- Memory usage by Docker (via Dazel) was causing crashes on our limited-memory GitHub Actions runners.
- Dazel is no longer useful now that we mostly use Codespaces, so we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍🏻
Final thing: let's also link #599 in the PR description.
754f231
to
846077b
Compare
@onelxj what's the status of this? Does this fix the build? |
1c4ff7f
to
95bc2b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try adding this to .bazelrc
:
# By default run both (target) compilation mode and host compilation
# mode in 'fastbuild' so that any "tools" that get build (which are
# built for the host) don't require building things a second time.
build --compilation_mode=fastbuild
build --host_compilation_mode=fastbuild
Turn on address sanitizer for ubuntu runner #599