Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of annoying clang-tidy checks #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NikitaNikolaenko
Copy link
Contributor

Removes the following very annoying checks:

  1. modernize-use-trailing-return-type - this check constantly notifies about an option to use smth like this:
auto add_two_values(int a, int b) -> int

Useless and is not used in eventuals codebase.

  1. readability-function-cognitive-complexity - eventuals by their nature have extremely complex codebase, some of the functions have a cognitive complexity of 300+, this check acts more like a noise at this point.

  2. readability-identifier-length - eventuals use one-letter-variables extensively across the codebase, no need for this check today.

@NikitaNikolaenko NikitaNikolaenko requested a review from benh April 27, 2023 04:31
@aviator-app
Copy link

aviator-app bot commented Apr 27, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue-ready label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant