Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce HeapSize() #569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce HeapSize() #569

wants to merge 1 commit into from

Conversation

ArthurBandaryk
Copy link
Contributor

This PR adds the possibility to determine for a chain of
eventuals the maximum amount of heap memory that needs to
get allocated.

@ArthurBandaryk ArthurBandaryk self-assigned this Aug 26, 2022
@ArthurBandaryk ArthurBandaryk marked this pull request as draft August 26, 2022 13:48
@ArthurBandaryk ArthurBandaryk requested review from benh and onelxj August 29, 2022 15:45
@ArthurBandaryk ArthurBandaryk force-pushed the artur.heap-size branch 2 times, most recently from a803f92 to 1833d73 Compare August 31, 2022 15:42
@ArthurBandaryk ArthurBandaryk marked this pull request as ready for review August 31, 2022 15:46
benh
benh requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@benh benh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding checks for heap size in every test, let's create some new tests to show that types that don't have any heap size equal zero but those that do are a value greater than zero.

eventuals/task.h Outdated Show resolved Hide resolved
eventuals/task.h Outdated Show resolved Hide resolved
eventuals/task.h Outdated Show resolved Hide resolved
test/range.cc Outdated Show resolved Hide resolved
@ArthurBandaryk
Introduce HeapSize()
2088439 
This PR adds the possibility to determine for a chain of
eventuals the maximum amount of heap memory that needs to
get allocated.
@ArthurBandaryk ArthurBandaryk requested a review from benh September 7, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onelxj onelxj Awaiting requested review from onelxj

@benh benh Awaiting requested review from benh

Requested changes must be addressed to merge this pull request.

Assignees

@ArthurBandaryk ArthurBandaryk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurBandaryk @benh