This repository has been archived by the owner on Mar 28, 2022. It is now read-only.
Bump version of stout-eventuals, fix local build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while-false
force-pushed
the
while-false.update_stout_eventuals
branch
from
a2f8da3 to
3401b58
Compare
Update stout-eventuals in light of recent changes, in particular the inclusion of Post and Get that relies on curl. The inclusion of curl introduces two new repo dependencies included in this commit. As outlined in issue #17, building `:grpc` locally using `gcc` is currently broken by `.bazelrc`. This commit works around it by removing the offending compiler flags, allowing the library to be built locally. This fixes local compilation but it does not fix the issue: we want those compiler flags in there where possible, i.e., for `clang`.
while-false
force-pushed
the
while-false.update_stout_eventuals
branch
from
3401b58 to
d96d19b
Compare
rjhuijsman
approved these changes
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update stout-eventuals in light of recent changes, in particular the
inclusion of Post and Get that relies on curl. The inclusion of curl
introduces two new repo dependencies included in this commit.
As outlined in issue #17, building
:grpclocally usinggcciscurrently broken by
.bazelrc. This commit works around it by removingthe offending compiler flags, allowing the library to be built locally.
This fixes local compilation but it does not fix the issue: we want those
compiler flags in there where possible, i.e., for
clang.