Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Add E2E about iframe in a popup #4956

Closed
wants to merge 1 commit into from
Closed

Tests - Add E2E about iframe in a popup #4956

wants to merge 1 commit into from

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Nov 7, 2024

Ticket : #4863

Follow up from #4953

I was hesitating in the selector or what to check exactly @nboisteault

Funded by Valabre

Just to keep track of previous selector

//        await expect(page.locator('.lizmapPopupContent > .lizmapPopupSingleFeature .lizmapPopupDiv iframe:nth-child(1)')).toHaveCount(1);

@Gustry Gustry added sponsored development This development has been funded tests unit tests and docker configuration for tests run end2end If the PR must run end2end tests or not backport release_3_7 backport release_3_8 backport release_3_9 labels Nov 7, 2024
@github-actions github-actions bot added this to the 3.10.0 milestone Nov 7, 2024
@Gustry Gustry mentioned this pull request Nov 7, 2024
Merged
@Gustry
Copy link
Member Author

Gustry commented Nov 7, 2024

Covered in #4955

@Gustry Gustry closed this Nov 7, 2024
@Gustry Gustry deleted the popup-iframe branch November 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nboisteault nboisteault Awaiting requested review from nboisteault

Assignees
No one assigned
Labels
backport release_3_8 backport release_3_9 run end2end If the PR must run end2end tests or not sponsored development This development has been funded tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Gustry