Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGN search string length must be between 3 and 200 chars #4840

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

@github-actions github-actions bot added this to the 3.9.0 milestone Oct 4, 2024
@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Oct 4, 2024
assets/src/modules/Search.js Outdated Show resolved Hide resolved
@nboisteault nboisteault merged commit 4adf5dd into 3liz:master Oct 7, 2024
12 of 13 checks passed
@nboisteault nboisteault deleted the ign-completion branch October 7, 2024 13:51
@3liz-bot
Copy link
Contributor

3liz-bot commented Oct 7, 2024

The backport to release_3_7 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 2e513f528... IGN search string length must be between 3 and 200 chars
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout
CONFLICT (modify/delete): assets/src/modules/Search.js deleted in HEAD and modified in 2e513f528 (IGN search string length must be between 3 and 200 chars).  Version 2e513f528 (IGN search string length must be between 3 and 200 chars) of assets/src/modules/Search.js left in tree.
Auto-merging lizmap/modules/view/locales/en_US/dictionnary.UTF-8.properties

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4840-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 2e513f528a24a26a96ffabe47a42f243baae3440
# Push it to GitHub
git push --set-upstream origin backport-4840-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7

Then, create a pull request where the base branch is release_3_7 and the compare/head branch is backport-4840-to-release_3_7.

@nboisteault
Copy link
Member Author

I won't backport in 3.7 as it is not critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 failed backport run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants