Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overview group name no more case sensitive #3804

Merged
merged 2 commits into from
Jul 28, 2023
Merged

overview group name no more case sensitive #3804

merged 2 commits into from
Jul 28, 2023

Conversation

nboisteault
Copy link
Member

Funded by 3Liz

@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Jul 27, 2023
@nboisteault nboisteault added this to the 3.7.0 milestone Jul 27, 2023
@nboisteault nboisteault self-assigned this Jul 27, 2023
@nboisteault
Copy link
Member Author

e2e tests coming

@Gustry
Copy link
Member

Gustry commented Jul 27, 2023

Thanks

Related to 3liz/lizmap-plugin#510

It will not be backported, right ? (just to know for the plugin, CF my PR)

@nboisteault
Copy link
Member Author

@Gustry yes, no backport.

@nboisteault
Copy link
Member Author

@rldhont I'll make the Static scale for the overview map test later.

@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Jul 28, 2023
@nboisteault nboisteault marked this pull request as ready for review July 28, 2023 14:28
@nboisteault nboisteault merged commit 8cb7603 into 3liz:master Jul 28, 2023
10 checks passed
@nboisteault nboisteault deleted the overview-lowercase branch July 28, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont approved these changes

@Gustry Gustry Awaiting requested review from Gustry

Assignees

@nboisteault nboisteault

Labels
enhancement refactoring run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nboisteault @Gustry @rldhont