Fix building of queries requiring SELECT DISTINCT #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #262.
In some cases, the query specified for a CityGML export leads to a
SELECT
statement that chooses theENVELOPE
column fromCITYOBJECT
and at the same time requiresDISTINCT
to avoid duplicates. WhileDISTINCT
can be used for theENVELOPE
column under PostgreSQL/PostGIS, this combination leads to an error under Oracle (see #262).This PR fixes the issue by avoiding
DISTINCT
in case theENVELOPE
column is selected. Instead, the query is rewritten to userow_number()
andORDER BY
to avoid duplicates.