CityJSON export #166
Merged
CityJSON export #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects and attributes
…ssed outputs (zip, gz)
yaozhihang
reviewed
Jan 28, 2021
There was a problem hiding this comment.
@clausnagel Nice Implementation. Please check my comments below.
...ient/src/main/java/org/citydb/gui/modules/exporter/preferences/CityGMLExportPreferences.java
Show resolved
Hide resolved
...ient/src/main/java/org/citydb/gui/modules/exporter/preferences/CityGMLExportPreferences.java
Show resolved
Hide resolved
impexp-config/src/main/java/org/citydb/config/project/exporter/CityJSONOptions.java
Show resolved
Hide resolved
yaozhihang
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements the CityJSON export capabilities and solves #89.
Major contents:
As discussed in #92, a main challenge for the CityJSON export is that specific CityJSON properties such as the
"vertices"array must be kept in main memory and can only be released after the file has been completely written. This can lead to memory issues when exporting too many city objects to the same file.The CityJSON community is currently working on streaming support for CityJSON. This will solve the issue in the future because it will allow us to apply the same chunk-wise processing approach as we use it for CityGML files.
In the meantime, users should use tiling for CityJSON exports. The exporter will raise a warning dialog if tiling is not enabled. We could also think about applying an automatic tiling to CityJSON exports. But this would require more substantial code changes, so I would like to keep this discussion out of this PR.