Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostGIS as default database connection #162

Merged
merged 1 commit into from
Jan 8, 2021
Merged

PostGIS as default database connection #162

merged 1 commit into from
Jan 8, 2021

Conversation

benediktschwab
Copy link
Contributor

As far as I am aware, the majority use the Importer/Exporter for a PostgreSQL/PostGIS database solution.
Could the PostGIS option in the GUI be the default selection for a new database connection?

@clausnagel
Copy link
Member

Thanks for your PR, @b-schwab. I don't know whether your assumption is correct but I have no objection to changing the default database for new connections :-) I am not sure but there might be more places in the code where Oracle is used as default.

But before looking into this, are there any other opinions?

@BWibo
Copy link
Member

BWibo commented Jan 7, 2021

I fully agree to switch to PostgreSQL/PostGIS as default setting.
The change does no harm anybody and I assume as well that the PostgreSQL/PostGIS user base is much larger.

@clausnagel
Copy link
Member

Ok, will merge this now. The CLI already uses PostgreSQL as default. I will do one more change to the org.citydb.config.project.database.DatabaseType enum after merging.

@clausnagel clausnagel merged commit c1e4cc4 into 3dcitydb:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants