refactor banner to conform to mediaType format #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryc33x
reviewed
Oct 13, 2020
terryc33x
reviewed
Oct 13, 2020
terryc33x
reviewed
Oct 13, 2020
terryc33x
reviewed
Oct 13, 2020
terryc33x
reviewed
Oct 13, 2020
terryc33x
reviewed
Oct 13, 2020
carlosfelix
pushed a commit
that referenced
this pull request
Sep 10, 2021
…ata (prebid#7167) * DL-1746: Remove trId and use notid instead (#31) * Remove trId and use notid instead * Update version to 0.7.3 * Set default value to empty string Co-authored-by: SublimeJeremy <[email protected]> * DL-1780: Fix pubtimeout (#32) * Update timeout value with onTimeout data * Add test for onTimeout * Update state with timeout asap Co-authored-by: SublimeJeremy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further refactors existing request construction for banner to make it conform to
mediaTypes. Also organizingBUILD REQUESTSinto sub-actions for better legibility. Associated unit tests also had to be changed.NOTE: This PR does not include building video format request yet.