-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Setup tool #81
WIP Setup tool #81
Conversation
Grabs the boilerplate and customises it a little
Yay, repetition
Pull Request Test Coverage Report for Build 871789306
💛 - Coveralls |
This is an excellent idea and appears to work well, nice! It's a shame the SDK path doesn't tab complete, but that looks to be... rocky territory: pallets/click#173 Some feedback at the very end of the process- ie: "Your new project has been created in: project-dir" would be nice. It sort of trails off after "downloading boilerplate."
I also can't begin to imagine how we'd test this using conventional means, but I guess an action could build/install the tools and actually just run the commands directly. |
Fixed up some more windows stuff (backslashes...) also added the slightly silly VS cmd.exe workaround. Still need to add some error handling, explodes a bit if the SDK/boilerplate git stuff goes wrong for some reason. Good point on the feedback (I think I intended to do that, but forgot... oops). And yeah, unsure on tests. Hmm, may need to tweak the "SDK not found" bit, you can currently automate everything else. EDIT: And the arm gcc check probably fails for VS as its toolchain isn't in PATH. (I seem to have a second one installed). |
Ugh, okay that PATH fix only works if you configure then add it since it overwrites the one VS is providing... which provides the tools and no system paths... It's also supposed to be fixed: https://developercommunity.visualstudio.com/t/cmdexe-is-not-recognized-when-using-cmake-with-nin/367003#T-N429389 (and the provided workaround doesn't work either!) |
This workflow will test the setup tool and that the output project builds (on Linux, STM32 build) - https://github.com/Gadgetoid/32blit-tools/blob/setup-tool/.github/workflows/test-setup.yml Doesn't help coveralls, but we can just ignore that. |
Usually because a windows path isn't escaped right
This is enough to find all the tools if you're running in a developer command prompt.
Thank you. I need to coordinate a release now 😬 |
Helps setting up a new project/ getting the SDK. Probably needs more error handling and tests,