Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Switch to action-gh-release. #870

Merged
merged 1 commit into from
Oct 30, 2024
Merged

CI: Switch to action-gh-release. #870

merged 1 commit into from
Oct 30, 2024

Conversation

Gadgetoid
Copy link
Contributor

Switch from the long deprecated upload-release-asset to action-gh-release and attempt to replicate the same behaviour.

Avoids nodejs and set-output deprecation warnings:

I've put this off for too long! upload-release-asset has been deprecated and unmaintained for years, causing a growing number of warnings in the Actions output.

Test release: https://github.com/32blit/32blit-sdk/releases/tag/TEST-DO-NOT-EAT

Switch from the long deprecated upload-release-asset to action-gh-release
and attempt to replicate the same behaviour.

Avoids nodejs and set-output deprecation warnings:
- https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
- https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@Daft-Freak
Copy link
Collaborator

No warnings, less code and it works... seems like a win. (Was also avoiding this when updating actions)

@Gadgetoid
Copy link
Contributor Author

Will merge and hope it doesn't cause us a headache for the next release!

There should probably be a release soon. You've been busy 😆 v0.3.2...master

@Gadgetoid Gadgetoid merged commit 8def062 into master Oct 30, 2024
26 checks passed
@Daft-Freak Daft-Freak deleted the patch-release-assets branch October 30, 2024 20:07
@Daft-Freak
Copy link
Collaborator

Mmm, haven't even merged any of the big stuff yet... and now I have a bunch of fixes from working on a HSTX driver. 🤔

@Gadgetoid
Copy link
Contributor Author

Mmm, haven't even merged any of the big stuff yet... and now I have a bunch of fixes from working on a HSTX driver. 🤔

Oooooooooo!

To be fair, a release of miscellaneous bugfixes probably isn't a bad thing to do before the big stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants