pico: SD storage fixes #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little faster and more reliable on RP2350
Now it will work with a clock speed other than 125 or 250MHz... like the default of 150Mhz on an RP2350. Adds a #define to control the overclock, which is enabled by default for now to match the old behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch finally replaces the "storage available" stub with an actual implementation and doesn't claim there's storage if there's no card detected.
Second fixes the USB MSC code to report no medium if no card, which stops the host from polling repeatedly, causing timeouts reading the non-existent card and upsetting everything.
Third optimises block reads a bit, mostly because it ended up slightly too slow on RP2350 causing frequent read corruption. (That part should maybe be using DMA)
(Still need to update SD code to not assume clock is 125 or 250MHz, but it's currently working okay because we overclock everything to 250 still...)