blit_executable(_int_flash) improvements #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently just builds the list of source files
This is an alternative to blit_executable_int_flash, similar to add_executable with WIN32 or MACOSX_BUNDLE
Daft-Freak
force-pushed
the
blit-executable
branch
from
cd9845c to
a50f30a
Compare
|
oooh! Tidy! I guess there are precious few projects using this at all so it's a pretty safe merge? |
|
If any, you'd have to manually pull in 32blit-stm32's CMakeLists to get (Hmm, if anyone was doing that, it would probably still work as the function is still there...) |
|
Boop beep I am ... not a bot 😆 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this replaces
blit_executable_int_flash(name crc.cpp)withblit_executable(name INTERNAL_FLASH src.cpp)but also:-DBLIT_EXECUTABLE_INTERNAL_FLASH=(Somewhat inspired by
add_executable(WIN32/MACOSX_BUNDLE)... and needing a similar thing for pico standalone/loader builds)