1주차 기본,도전,심화과제 PR #6

meenyweeny · 2022-04-07T13:41:28Z

🌱 작업한 내용

기본과제 구현
도전과제1 구현
도전과제2 구현
심화과제 구현

🌱 PR Point

안녕하세요 ,, 너무 별 거 없어서,, 실망하셧죠 ,, (꾸벅)
오토레이아웃을 안배워서 레이아웃을 정말.. 막 짰습니다!
Main 스토리보드는 후에 분명 탭바를 만들 것 같아서, 이번엔 안썼지만 밖에 따로 남겨뒀습니다!
한 스토리보드에 해도 충분히 커버될 1차 과제지만,, 협업에서는 나누니까! 그냥 일부러 나눠보았어요~!
코드에 대한 이해가 충분하지 않았어서 다른 스토리보드로의 화면전환도 어려워했던 저의 모습을 떠올리며
그 부분 코드를 좀 눈에 익숙하게 보여드리고자 나눠서 해보았습니다!
(그니까 철저히 처음 하는 YB 입장에서 짠 코드.. 라는 말~ ^__^)
좀 더 효율적일 부분이,, 있을 수 있겠지만,, 최대한 이지하게 갈겨보았답니다? 조언해주세요 뀨 ㅋㅋ
removeTextField는.. 제 사랑 뷰의 생명주기의 중요성 + (텍스트 남아있는게 거슬려서,,) 넣어보앗어요 ~!
Extension은,, 에셋 얼추 넣고 한번에 쏵 해보겠습니다~! 이번 과제 .. 에셋.. 안넣엇거든요 .. ^__^ .. 씨익

📸 스크린샷

구현 내용	스크린샷
로그인
회원가입
clear button(도전과제1)
버튼 활성화 (도전과제2)
눈모양누르기 (심화과제)

📮 관련 이슈

Resolved: [FEAT] iOS 1주차 과제 #2

inuinseoul

깔쌈하네용

inuinseoul · 2022-04-07T13:52:07Z

assignment/assignment/Scene/Login/LoginViewController.swift

+    // MARK: - objc function
+
+    @objc func textFieldDidChange(_ sender: UITextField) {
+        loginButton.isEnabled = emailTextField.hasText && passwordTextField.hasText


오 텍스트필드에 hasText라는 프로퍼티가 있나보네요 몰랐어요!

haeText 사용하는게 더 깔끔해보이네요! 배우고 가요~!

hyesuuou

역시 ㅋㅋ 최고티비 ㅋㅋ ❤️

hyesuuou · 2022-04-07T15:37:03Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+    private func setUI() {
+        setButtonUI()
+    }
+
+    private func setButtonUI() {
+        nextButton.layer.cornerRadius = 15
+    }
+
+    private func setTextField() {
+        nameTextField.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+    }
+


하 함수나눈거 너무좋아여 ㅋ sarang

hyesuuou · 2022-04-07T15:38:58Z

assignment/assignment/Scene/Login/LoginViewController.swift

+
+    // MARK: - IBAction
+
+    @IBAction func showPasswordButtonDidTap(_ sender: Any) {


DidTap이 이렇게 사람을 행복하게 하는 네이밍이엇나요?

Suyeon9911 · 2022-04-07T18:34:13Z

assignment/assignment/Scene/Login/LoginViewController.swift

+
+    private func setTextField() {
+        [emailTextField, passwordTextField].forEach {
+            $0?.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+        }
+    }


오 delegate 대신 addTarget ~ 좋네요 깔끔하네요

88yhtserof

저는 항상 한 스토리보드에 모든 View를 만들었는데 협업 때는 여러 스토리보드로 나누는게 좋은가요?
그리고 코드 잘 보고 가요~!!~!!

88yhtserof · 2022-04-08T03:57:45Z

assignment/assignment/Scene/Complete/CompleteViewController.swift

+    @IBOutlet weak var welcomeLabel: UILabel!
+    @IBOutlet weak var completeButton: UIButton!
+
+    // MARK: - LifeCycle


MARK 주석은 따로 적는건가요?
한 번도 안 해봤는데 코드 보기에 좋네요!! 저도 해야겠어요~~~~~!!

MARK 주석 썼을때 효과 .. 별 거 아니지만 오늘 퇴근하구.. 노션에 꼭 적어 올려드릴게요~!

88yhtserof · 2022-04-08T04:05:39Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+    private func setTextField() {
+        nameTextField.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+    }
+


모든 함수가 간략하고 깔끔해요! 저도 조금 더 작게 나눠서 깔끔하게 만들어 볼게요!!

88yhtserof · 2022-04-08T04:07:11Z

assignment/assignment/Scene/Join/JoinPasswordViewController.swift

+    }
+
+    private func removeTextField() {
+        passwordTextField.text?.removeAll()


저는 "" 로 초기화 했는데 다음부터는 removeAll 메서드를 써야겠어요..!

88yhtserof · 2022-04-08T07:59:22Z

assignment/assignment/Scene/Join/JoinPasswordViewController.swift

+        completeVC.modalPresentationStyle = .fullScreen
+        completeVC.userName = userName
+        self.present(completeVC, animated: true) {
+            self.navigationController?.popToRootViewController(animated: false)


생각못했는데 present하면서 먼저 popToRoot하는 방법도 좋은 것 같아요!!

오홍 ~ 이런 방법도 있군요 !!

0inn · 2022-04-08T08:46:50Z

assignment/assignment/Scene/Login/LoginViewController.swift

+        }
+    }
+
+    private func removeTextField() {


오 ,, removeTextField 생각도 못한 부분이네요 ,, 선배님 ,, 멋져요 ,,, 경민 선배 ,, 나만의 명예솝트관 ,,, 역시 ,, 매일 찾아와서 봐야겠다 ,,,

pcsoyeon

코드가 엄청 깔끔해서 가독성이 미쳤네요 .. 많이 배워갑니다 ~~

pcsoyeon · 2022-04-08T16:31:34Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+
+    @IBAction func nextButtonDidTap(_ sender: Any) {
+        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: "JoinPasswordViewController") as? JoinPasswordViewController else { return }
+        passwordVC.userName = nameTextField.text ?? ""


Suggested change

passwordVC.userName = nameTextField.text ?? ""

guard let name = nameTextField.text else { return }

passwordVC.userName = name

이런식으로 guard let 구문을 활용해서 옵셔널 처리를 할 수 있을 것 같아요 !!

pcsoyeon · 2022-04-08T16:32:16Z

assignment/assignment/Scene/Join/JoinPasswordViewController.swift

+        completeVC.modalPresentationStyle = .fullScreen
+        completeVC.userName = userName
+        self.present(completeVC, animated: true) {
+            self.navigationController?.popToRootViewController(animated: false)


오홍 ~ 이런 방법도 있군요 !!

dlwns33

경민아 너무 잘해서 리뷰할게 없음 티비 ㅋㅋ

dlwns33 · 2022-04-08T17:16:07Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+    @IBAction func nextButtonDidTap(_ sender: Any) {
+        guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: "JoinPasswordViewController") as? JoinPasswordViewController else { return }


Identifier은 혹시 오타가 날수도 있으니 Constant 또는 뷰컨 swift 파일에 미리 적어두는 방법도 좋아!
나중에 Const.VC.JoinPasswordViewController 뭐 이런식으로 자동완성이 될 수 있도록!

0lynny

선배님 코드 잘보구 갑니다!

0lynny · 2022-04-10T09:58:16Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(animated)
+        removeTextField()
+    }


앱 생명주기로 다시 돌아왓을 때 textfield지우는 법 배우고 갑니다! 덕분에 앱 생명주기도 찾아보고 왔어용:)

0lynny · 2022-04-10T10:03:27Z

assignment/assignment/Scene/Login/LoginViewController.swift

+    private func setTextField() {
+        [emailTextField, passwordTextField].forEach {
+            $0?.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+        }


제가 찾던 방법이 이거였어요..! 제 코드에서 동일한 구조를 두번 사용해서 똑똑한 코드로 바꾸고 싶었는데 !! 문법 공부의 필요성을 느낍니다!

딜리게이트 말고 이렇게 되는거 몰랐던...ㅎㅎ 잘 배워가여~

0lynny · 2022-04-10T10:04:14Z

assignment/assignment/Scene/Login/LoginViewController.swift

+    // MARK: - objc function
+
+    @objc func textFieldDidChange(_ sender: UITextField) {
+        loginButton.isEnabled = emailTextField.hasText && passwordTextField.hasText


haeText 사용하는게 더 깔끔해보이네요! 배우고 가요~!

yujindonut · 2022-04-11T01:57:09Z

assignment/assignment/Scene/Join/JoinNameViewController.swift

+        nameTextField.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+    }
+
+    private func removeTextField() {


진짜 함수를 쪼개서 보니까 코드 이해하기에 너무너무 좋아요!!!! ,,, 세상에,,

yujindonut · 2022-04-11T01:58:39Z

assignment/assignment/Scene/Join/JoinPasswordViewController.swift

+        setButtonUI()
+    }
+
+    private func setButtonUI() {


버튼 ui도 이런식으로 함수로 쪼개는 방법 ,,, 알아갑니다 !!!💛

L-j-h-c

1차 과제 수고하셨어유~~!!

L-j-h-c · 2022-04-11T03:57:19Z

assignment/assignment/Scene/Login/LoginViewController.swift

+    private func setTextField() {
+        [emailTextField, passwordTextField].forEach {
+            $0?.addTarget(self, action: #selector(textFieldDidChange(_:)), for: .editingChanged)
+        }


딜리게이트 말고 이렇게 되는거 몰랐던...ㅎㅎ 잘 배워가여~

meenyweeny and others added 8 commits April 7, 2022 13:56

[#2] 1주차 기본과제 구현 완료

c379c2b

[#2] 1주차 기본과제 TextField option 수정

577604b

Merge branch 'main' into feature/#2

cf15c9c

[#2] 1주차 도전과제1 - clear button

bbe4221

[#2] 1주차 도전과제2 - Button 활성화 logic

90cad61

[#2] 1주차 화면전환시 TextField option 초기화

cc98109

[#2] 1주차 심화과제 - 비밀번호 보이기/안보이기

c0f7d57

[#2] (+ 버튼 초기값 변경)

51749bf

meenyweeny added PR meenyweeny labels Apr 7, 2022

meenyweeny requested review from pcsoyeon, Taehyeon-Kim, 88yhtserof, hyesuuou, inuinseoul and yujindonut April 7, 2022 13:41

meenyweeny self-assigned this Apr 7, 2022

meenyweeny requested a review from 0lynny April 7, 2022 13:48

inuinseoul reviewed Apr 7, 2022

View reviewed changes

meenyweeny added the assignment label Apr 7, 2022

hyesuuou reviewed Apr 7, 2022

View reviewed changes

Suyeon9911 reviewed Apr 7, 2022

View reviewed changes

88yhtserof reviewed Apr 8, 2022

View reviewed changes

meenyweeny requested a review from 0inn April 8, 2022 08:40

0inn reviewed Apr 8, 2022

View reviewed changes

pcsoyeon reviewed Apr 8, 2022

View reviewed changes

dlwns33 approved these changes Apr 8, 2022

View reviewed changes

meenyweeny requested a review from L-j-h-c April 9, 2022 06:08

0lynny reviewed Apr 10, 2022

View reviewed changes

yujindonut reviewed Apr 11, 2022

View reviewed changes

L-j-h-c reviewed Apr 11, 2022

View reviewed changes

meenyweeny merged commit 9cf34a5 into main Apr 12, 2022

meenyweeny deleted the feature/#2 branch April 12, 2022 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1주차 기본,도전,심화과제 PR #6

1주차 기본,도전,심화과제 PR #6

meenyweeny commented Apr 7, 2022 •

edited

Loading

inuinseoul left a comment

inuinseoul Apr 7, 2022

0lynny Apr 10, 2022

hyesuuou left a comment

hyesuuou Apr 7, 2022

hyesuuou Apr 7, 2022

Suyeon9911 Apr 7, 2022

88yhtserof left a comment

88yhtserof Apr 8, 2022

meenyweeny Apr 8, 2022

88yhtserof Apr 8, 2022

88yhtserof Apr 8, 2022

88yhtserof Apr 8, 2022

pcsoyeon Apr 8, 2022

0inn Apr 8, 2022

pcsoyeon left a comment

pcsoyeon Apr 8, 2022

pcsoyeon Apr 8, 2022

dlwns33 left a comment

dlwns33 Apr 8, 2022

0lynny left a comment

0lynny Apr 10, 2022

0lynny Apr 10, 2022

L-j-h-c Apr 11, 2022

0lynny Apr 10, 2022

yujindonut Apr 11, 2022

yujindonut Apr 11, 2022

L-j-h-c left a comment

L-j-h-c Apr 11, 2022


		// MARK: - IBAction

		@IBAction func showPasswordButtonDidTap(_ sender: Any) {

	passwordVC.userName = nameTextField.text ?? ""
	guard let name = nameTextField.text else { return }
	passwordVC.userName = name

		@IBAction func nextButtonDidTap(_ sender: Any) {
		guard let passwordVC = self.storyboard?.instantiateViewController(withIdentifier: "JoinPasswordViewController") as? JoinPasswordViewController else { return }

1주차 기본,도전,심화과제 PR #6

1주차 기본,도전,심화과제 PR #6

Conversation

meenyweeny commented Apr 7, 2022 • edited Loading

🌱 작업한 내용

🌱 PR Point

📸 스크린샷

📮 관련 이슈

inuinseoul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyesuuou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

88yhtserof left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcsoyeon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlwns33 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0lynny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

L-j-h-c left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meenyweeny commented Apr 7, 2022 •

edited

Loading