3주차 과제 PR #24
Merged
3주차 과제 PR #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0lynny
reviewed
May 8, 2022
| var cellHeight: CGFloat = 0 | ||
| switch indexPath.item { | ||
| case 0: cellHeight = 72 | ||
| default: cellHeight = 488 + (CGFloat)((indexPath.item-1) * 12) |
There was a problem hiding this comment.
이건 제가,, 억지로 셀 사이즈를 늘려버리기 위해 일케 쓴 거라서
신경쓰지 않아도 되는 ,, 억지 코드 ^___^~
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell { | ||
| if indexPath.item == 0 { |
There was a problem hiding this comment.
indexPath.item이 indexPath.section이랑 같은역할을 하는 건가요?
There was a problem hiding this comment.
indexPath.row랑!!! section이랑은 달라요!
하나의 section 안에 여러개의 row가 들어가있는 고런 느낌~!
Comment on lines
+48
to
+53
| @objc private func refreshCollectionView(refresh: UIRefreshControl) { | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) { | ||
| self.collectionView.reloadData() | ||
| refresh.endRefreshing() | ||
| } | ||
| } |
There was a problem hiding this comment.
저건 그냥 원하는 시간 차 두고 실행하고 싶을 때 쓰는건데
refreshControl 때문에 가져다 넣었답니닷,,~!
서버 연결 함수와 함께라면,, 이해가 잘 갈텐데,, 서버가 없네,,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
과제를 했습니다
🌱 PR Point
하트 버튼 누르면 이벤트는 그냥 로그인 창 모달로 올라오게 아무거나 넣었고요,, (의미 없음)
... 테이블뷰를안써버렷어요 미안합니다..
셀 사이즈 다르게 하는 건.. 일단 그냥 수식으로 냅다 계산해놓고 바꾸려고 했는데.. 벌써 금요일이 되었네요
테이블 뷰로 바꿔서 .. 제대로 된 코드로 빨리 올려볼게요.. 그래서 리뷰어 등록을 아직 안해놨습니다..
📸 스크린샷
..미안합니다 빠르게 올리겠습니다?
📮 관련 이슈