버그 수정 및 문서 업데이트

2skydev · May 25, 2024 · dbae448 · dbae448
1 parent ed268cd
commit dbae448
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Release drafter
-        uses: release-drafter/release-drafter@v5
+        uses: release-drafter/release-drafter@v6
         with:
           config-name: release-drafter-config.yml
         env:
@@ -34,7 +34,7 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -59,15 +59,15 @@ jobs:
     needs: release_draft
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: main # ref를 main 설정하지 않으면 workflow가 트리거된 ref가 사용됨 (`Update package.json version` 단계의 커밋 반영을 위해 main으로 설정)
 
       - name: Setup Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
-          cache: 'yarn'
+          node-version: 20
+          cache: 'pnpm'
 
       - name: Generate environment variables file
         run: |
@@ -76,9 +76,9 @@ jobs:
           echo "RENDERER_VITE_SENTRY_DSN=${{ vars.RENDERER_VITE_SENTRY_DSN }}" >> .env
 
       - name: Install dependencies
-        run: yarn
+        run: pnpm
 
       - name: Build
-        run: yarn build
+        run: pnpm build
         env:
           GITHUB_TOKEN: ${{ secrets.PERSONAL_TOKEN }} # electron-builder은 자동 인증 토큰을 지원하지 않음
diff --git a/README.md b/README.md
@@ -4,9 +4,9 @@
 
 Electron starter kit with multiple features
 
-![스크린샷 2024-05-25 180904](https://github.com/2skydev/electron-nestjs-react-vite-template/assets/43225384/5b717dd7-24e1-4a86-8df7-b1d93a986d46)
+![image](https://github.com/2skydev/electron-nestjs-react-vite-template/assets/43225384/5b717dd7-24e1-4a86-8df7-b1d93a986d46)
 
-![스크린샷 2024-05-25 181018](https://github.com/2skydev/electron-nestjs-react-vite-template/assets/43225384/47cb748a-52de-4e93-89b1-90a92b455e24)
+![image](https://github.com/2skydev/electron-nestjs-react-vite-template/assets/43225384/47cb748a-52de-4e93-89b1-90a92b455e24)
 
 <br/>
 
@@ -71,3 +71,11 @@ pnpm dev
 ```bash
 pnpm build
 ```
+
+## known error
+
+- [%1 is not a valid Win32 application](https://github.com/pnpm/pnpm/issues/5638#issuecomment-1327988206)
+- Github Action
+  - Update package.json version
+    - `pathspec 'dev' did not match any file(s) known to git`
+      - DO: create `dev` branch from `main`