Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP -- supporting remote integration testing #1

Open
wants to merge 2 commits into
base: allow-integration-tests-on-remote-horizon
Choose a base branch
from

Conversation

paulbellamy
Copy link

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

2opremio and others added 2 commits February 26, 2021 17:26
Introduce integration.NewTestForRemoteHorizon(), which allows integration-testing
a remote Horizon instance. This is useful for testing a Horizon deployment
(e.g. when deploying a new cluster or a new Horizon release).

TODO: add a simple wat to run all the integration tests without changing
      the contructor incovation (i.e. s/NewTest()/NewTestForRemoteHorizon()/) of all the tests.
@2opremio 2opremio force-pushed the allow-integration-tests-on-remote-horizon branch 4 times, most recently from f4ee250 to 7d18fe9 Compare June 29, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants