Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding seaborn #5

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Adding seaborn #5

merged 1 commit into from
Jul 5, 2021

Conversation

sawula
Copy link
Collaborator

@sawula sawula commented Jul 1, 2021

Adding seaborn library. In part to confirm the procedure for adding libraries.

Adding seaborn library.  In part to confirm the procedure for adding libraries.
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

Binder 👈 Test his PR on Binder

@sawula
Copy link
Collaborator Author

sawula commented Jul 1, 2021

Adding seaborn.

@sawula sawula closed this Jul 1, 2021
@sawula sawula reopened this Jul 1, 2021
@damianavila
Copy link

@sawula I guess you do not have enough permissions to self-merge this one yet, am I right?

@sawula
Copy link
Collaborator Author

sawula commented Jul 3, 2021

@damianavila Yes. I believe I do not have the permission merge this pull request myself. @sgibson91 wondered whether I would earn that permission after my first merged pull request. This was a test of that conjecture as well as a case to work through to document the process.

@sgibson91
Copy link
Member

@sgibson91 wondered whether I would earn that permission after my first merged pull request.

Ah sorry, I meant that someone has to approve the tests to run for the first PR (now they should run automatically). We should absolutely give @sawula enough permissions to self-merge so the engineering team aren't a bottle neck :)

@sawula
Copy link
Collaborator Author

sawula commented Jul 5, 2021

i think this 5-day wait is for all of the times in my life that i've been impatient about something. i'm personally proud of my growth.

@sgibson91
Copy link
Member

@sawula I've just sent you an invite to collaborate on the project. Once you accept, you should be able to merge this PR yourself :)

@sawula sawula merged commit b46ac4c into 2i2c-org:main Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants