Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bootstrap 5 #72

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to Bootstrap 5 #72

wants to merge 4 commits into from
+24 −45

Conversation

oliverroick
Copy link
Collaborator

Implements #45

  • Updates form CSS classes, so we're using more Bootstrap CSS classes, specifically for error messaging. This allows us to remove some of the custom classes.
  • Update typography: Use h2 elements instead of custom label heading

@yuvipanda
Copy link
Member

This is great! We should hold off until jupyterhub 5 is rolled out to the veda hubs, as we're currently still on jupyterhub 4.x

This was referenced Nov 14, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverroick @yuvipanda