-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Service Principal for Azure clusters #864
Create a Service Principal for Azure clusters #864
Conversation
We will be authenticating using the service principal instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/ This is super awesome.
Our UToronto access doesn't let us create service principals. While we should eventually get that fixed, I don't want the migration to block on that. So we should try make these temporarily conditional.
Good to know, cheers! |
This reverts commit ae265a2.
Ok @yuvipanda I have now made it optional to create service principals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hmmmm, seems like I still don't have enough privileges - @jhamman?
|
Ok, I'm going to rescope this PR to not apply the change to carbonplan and then merge it. We can figure out the permissions to create a service principal for carbonplan later. |
Thanks @sgibson91 for working on this. Happy to adjust permissions as needed on our side. Confirming that right now, you do have the |
Thanks @jhamman. Knowing Azure, I am 100% confident that it's something far more complicated and annoying :) I will update the main issue tomorrow |
This PR updates our Azure Terraform config to create a service principal and secret and output these so we can use the info to login in a similar way to how GCP uses Service Accounts, and hence replacing the raw kubeconfig auth method.
This is the first piece for both #840 and #841