-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy some more hub automatically #569
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Deploy and Test carbonplan hub | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| paths: | ||
| - deployer/** | ||
| - hub-templates/** | ||
| - requirements.txt | ||
| - dev-requirements.txt | ||
| - config/secrets.yaml | ||
| - config/hubs/carbonplan.cluster.yaml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: google-github-actions/setup-gcloud@master | ||
| with: | ||
| version: '290.0.1' | ||
| # This is used for KMS only | ||
| project_id: two-eye-two-see | ||
| service_account_key: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
| export_default_credentials: true | ||
| - uses: azure/setup-helm@v1 | ||
| - uses: mdgreenwald/mozilla-sops-action@v1 | ||
| - uses: ./.github/actions/deploy | ||
| with: | ||
| cluster: 'carbonplan' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Deploy and Test meom-ige hub | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| paths: | ||
| - deployer/** | ||
| - hub-templates/** | ||
| - requirements.txt | ||
| - dev-requirements.txt | ||
| - config/secrets.yaml | ||
| - config/hubs/meom-ige.cluster.yaml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: google-github-actions/setup-gcloud@master | ||
| with: | ||
| version: '290.0.1' | ||
| # This is used for KMS only | ||
| project_id: two-eye-two-see | ||
| service_account_key: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
| export_default_credentials: true | ||
| - uses: azure/setup-helm@v1 | ||
| - uses: mdgreenwald/mozilla-sops-action@v1 | ||
| - uses: ./.github/actions/deploy | ||
| with: | ||
| cluster: 'meom-ige' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Deploy and Test COESSING hub | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| paths: | ||
| - deployer/** | ||
| - hub-templates/** | ||
| - requirements.txt | ||
| - dev-requirements.txt | ||
| - config/secrets.yaml | ||
| - config/hubs/pangeo-181919.cluster.yaml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: google-github-actions/setup-gcloud@master | ||
| with: | ||
| version: '290.0.1' | ||
| # This is used for KMS only | ||
| project_id: two-eye-two-see | ||
| service_account_key: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
| export_default_credentials: true | ||
| - uses: azure/setup-helm@v1 | ||
| - uses: mdgreenwald/mozilla-sops-action@v1 | ||
| - uses: ./.github/actions/deploy | ||
| with: | ||
| cluster: 'pangeo-181919' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is handling this "run on changes to a specific cluster.yaml file" the crux of the reason we are using workflow files per cluster rather than one file with a matrix job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgibson91 It wasn't intentional - i was just following the pattern @GeorgianaElena set up. It is nice to not run them when there's no changes though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! I was going to suggest using something like this action to set a conditional on the paths changed https://github.com/dorny/paths-filter
So we maintain the same behaviour of not doing a deploy when nothing's changed, but we can consolidate into a single workflow file and new clusters can just be added to the matrix element list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This shouldn't block the PR btw - merge away and we can open an issue to track this discussion if you like)