Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admins to carbonplan hub #567

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Add admins to carbonplan hub #567

merged 3 commits into from
Jul 30, 2021

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jul 30, 2021

I tried to mimic how this is done on the OpenScapes hub

closes #566

@yuvipanda
Copy link
Member

Let's do it like https://github.com/2i2c-org/pilot-hubs/blob/151faa89e92d7ca596a31bbe9e58e16de758a2f7/config/hubs/2i2c.cluster.yaml#L50 instead? That'll mean only the listed users can log in (right now anyone with GitHub can login lol), and they can add more users in the admin panel when they need to log in.

@yuvipanda
Copy link
Member

Also #558 is needed to deploy to the new carbonplan hub

@choldgraf
Copy link
Member Author

choldgraf commented Jul 30, 2021

ok I think this is what you mean? Do we also need to do this in the openscapes hub? https://github.com/2i2c-org/pilot-hubs/blob/151faa89e92d7ca596a31bbe9e58e16de758a2f7/config/hubs/openscapes.cluster.yaml

We should document this in the pilot hubs docs (maybe we should rename that to "Hub Engineer Handbook/guide/etc"?)

Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I think we should do this for openscapes (and all our hubs really), since otherwise anyone with a github login can get in.

The * and & are YAML anchors that need to be unique within the document, so they were <hubname>_users in 2i2c.clusters.yaml. Not the case here though.

There's docs on adding new users in https://pilot.2i2c.org/en/latest/admin/howto/manage-users.html, but we should have equivalent in the '2i2c engineer handbook'

config/hubs/carbonplan.cluster.yaml Outdated Show resolved Hide resolved
config/hubs/carbonplan.cluster.yaml Outdated Show resolved Hide resolved
Only one set of users in this file
@yuvipanda yuvipanda merged commit 677de80 into master Jul 30, 2021
@damianavila damianavila deleted the choldgraf-patch-1 branch August 6, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JupyterHub admin users to CarbonPlan hub
2 participants