Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document authentication mechanisms for gcloud #511

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Document authentication mechanisms for gcloud #511

merged 1 commit into from
Jul 14, 2021

Conversation

yuvipanda
Copy link
Member

Ref #476

@yuvipanda yuvipanda mentioned this pull request Jul 13, 2021
Closed
18 tasks
sgibson91
sgibson91 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, didn't actually know this! (I always do both anyway :D )

GeorgianaElena
GeorgianaElena approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only used the second one. Thanks @yuvipanda!

damianavila
damianavila approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgibson91 sgibson91 merged commit 1565a35 into 2i2c-org:master Jul 14, 2021
@choldgraf choldgraf mentioned this pull request Sep 4, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgibson91 sgibson91 sgibson91 approved these changes

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

@damianavila damianavila damianavila approved these changes

@choldgraf choldgraf Awaiting requested review from choldgraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuvipanda @damianavila @GeorgianaElena @sgibson91