Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy farallon staging hub from CD #387

Merged
merged 1 commit into from
May 12, 2021
Merged

Deploy farallon staging hub from CD #387

merged 1 commit into from
May 12, 2021

Conversation

yuvipanda
Copy link
Member

Ref #379

@yuvipanda yuvipanda requested a review from damianavila May 7, 2021 21:25
damianavila
damianavila approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the other workflows, this one looks pretty similar to them and LGTM.

GeorgianaElena
GeorgianaElena approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me too! Merging 🚀

@GeorgianaElena GeorgianaElena merged commit c943874 into 2i2c-org:master May 12, 2021
@yuvipanda yuvipanda mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

@damianavila damianavila damianavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuvipanda @damianavila @GeorgianaElena