-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping Docker image tags in JupyterHub config #1407
Bumping Docker image tags in JupyterHub config #1407
Conversation
…['2022.06.02', '2022.06.02'], respectively
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not sure if ml-notebook is pinned for a specific reason, so will revert the bump for now
Unsure if it was pinned for a specific reason, so will revert for now
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster |
Wondering if you should have a way to signal the action that we want to ignore some hubs (for specific reasons) 🤔. |
You can. A series of JMESPath expressions that define where the images are defined in the config are provided. Also, each hub is a separate matrix entry in the workflow file. I just setup the action to do all the environment images in the three Pangeo-like hubs and then realised that I didn't have the context to decide whether they should be bumped or not.
|
Super, I should have looked into the details before wondering... 😉 |
This Pull Request is bumping the Docker tags for the following images to the listed versions.
pangeo/pangeo-notebook
:2022.04.20
->2022.06.02
pangeo/ml-notebook
:master
->2022.06.02