Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Docker image tags in JupyterHub config #1407

Merged

Conversation

2i2c-token-generator-bot[bot]
Copy link
Contributor

This Pull Request is bumping the Docker tags for the following images to the listed versions.

  • pangeo/pangeo-notebook: 2022.04.20 -> 2022.06.02
  • pangeo/ml-notebook: master -> 2022.06.02

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not sure if ml-notebook is pinned for a specific reason, so will revert the bump for now

config/clusters/leap/common.values.yaml Outdated Show resolved Hide resolved
Unsure if it was pinned for a specific reason, so will revert for now
@sgibson91 sgibson91 merged commit 35ce60e into master Jun 9, 2022
@sgibson91 sgibson91 deleted the bump-image-tags/config-clusters-leap-commonvaluesyaml/xNBr branch June 9, 2022 10:55
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster

@damianavila
Copy link
Contributor

Again, not sure if ml-notebook is pinned for a specific reason, so will revert the bump for now

Wondering if you should have a way to signal the action that we want to ignore some hubs (for specific reasons) 🤔.

@sgibson91
Copy link
Member

sgibson91 commented Jun 14, 2022

Wondering if you should have a way to signal the action that we want to ignore some hubs (for specific reasons) 🤔.

You can. A series of JMESPath expressions that define where the images are defined in the config are provided. Also, each hub is a separate matrix entry in the workflow file. I just setup the action to do all the environment images in the three Pangeo-like hubs and then realised that I didn't have the context to decide whether they should be bumped or not.

images_info: '[{"values_path": ".basehub.jupyterhub.singleuser.image", "regexpr": "[0-9]{4}.[0-9]{2}.[0-9]{2}"}]'

@damianavila
Copy link
Contributor

Super, I should have looked into the details before wondering... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants