-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to developer onboarding documentation #351
Comments
@damianavila perhaps you could share a few other items (or just update the comment above) with some specific ways that the pilot hubs docs could be improved? |
I look forward to this, @damianavila! The current architecture is a bit slapdash, and this will give us an opportunity to keep this more focused. |
I've started #352 to refactor some of the things in this repo. I'm hoping that a combination of code review and refactoring will make this repository easier to understand :) |
Sure... let me paste here some of my notes about the pilot and pilot-hubs docs. pilot.2i2c.org (hub admin consumers)https://pilot.2i2c.org/en/latest/about/infrastructure.html
Should mention VSCode if there is an icon in the image...
Missing link https://pilot.2i2c.org/en/latest/about/projects.html Pangeo pilot should be mentioned first as in the previous section (https://pilot.2i2c.org/en/latest/about/infrastructure.html) https://pilot.2i2c.org/en/latest/admin/configuration/login.html#
I was expecting also to add users using the helm config file... https://pilot.2i2c.org/en/latest/admin/configuration/culling.html For the server culling, I know there is some way in binder to detect inactivity, should not be using that to prevent killing a long computation?
This is confusing... https://pilot.2i2c.org/en/latest/admin/configuration/default-interface.html The legacy notebook should have a picture as well... Do not we supppot VSCode? https://pilot.2i2c.org/en/latest/admin/howto/support.html Who is receiving the emails sent to [email protected]? https://pilot.2i2c.org/en/latest/admin/howto/configurator.html
Is there any validation before submitting the change?
So you need to auth twice?
A green message should help here...
How to prevent that failure or fail graciously...
How do we start with the selected interface? https://pilot.2i2c.org/en/latest/admin/howto/environment.html
VScode, Theia? Dupe from previous comments...
The default image should be as small as possible
With conda, you can "save" your temp environment as well... not sure about conflicts https://pilot.2i2c.org/en/latest/admin/howto/nbgitpuller.html automatically merged sound nice, wondering about issue with the process and if there is any thought about a conflict resolution UI in the future... https://pilot.2i2c.org/en/latest/admin/howto/create-content.html This section probably needs more love (development), right? https://pilot.2i2c.org/en/latest/admin/howto/manage-users.html Persistence of manually added users? Dupe question IIRC https://pilot.2i2c.org/en/latest/admin/howto/control-user-server.html Switch the warnings. Btw, the RTC does not apply here because you are actually impersonating the user... https://pilot.2i2c.org/en/latest/admin/howto/share-datasets.html Wondering how the shared-readwrite is implemented (there are some docs ahead) https://pilot.2i2c.org/en/latest/admin/howto/replicate.html
Any export tools to get the config you may use in your own deployment? https://pilot.2i2c.org/en/latest/admin/howto/create-billing-account.html Fix AWS link
We should use some generic user... or can others be invited by the two of you? (in any case, it is a bottleneck). https://pilot.2i2c.org/en/latest/user/download-data.html Interesting tool, jupyter-tree-download (is there a JLab counterpart?) https://pilot.2i2c.org/en/latest/user/interface.html VSCode? I will post my pilot-hub docs notes in the next message on this thread. |
pilot-hubs (2i2c eng docs)https://pilot-hubs.2i2c.org/en/latest/ hubs.yaml should be always links to the repo, IMHO.
Is the CI deploying the new hub somehow??? (I noticed that is the case after looking at the repo...) https://pilot-hubs.2i2c.org/en/latest/structure.html
Our site is not linking the Hub users/admin site? https://pilot-hubs.2i2c.org/en/latest/howto/configure/hub-config.html
No link
Any validation? https://pilot-hubs.2i2c.org/en/latest/howto/configure/auth-management.html# Double "Manage authentication" in ToC, the same for other sections... https://pilot-hubs.2i2c.org/en/latest/howto/configure/add-hub-domains.html
Ingress domain, interested to know more about this one... https://pilot-hubs.2i2c.org/en/latest/howto/configure/update-env.html
This should be automated!
CLI? Link missing... https://pilot-hubs.2i2c.org/en/latest/howto/customize/custom-image.html
How does the automatic deployment work? Looked at the repo, I think I have already got it... https://pilot-hubs.2i2c.org/en/latest/howto/customize/docs-service.html Why jupyterbook is not listed here? I should try Nikola with this one! https://pilot-hubs.2i2c.org/en/latest/howto/customize/configure-login-page.html
Interesting tool! https://pilot-hubs.2i2c.org/en/latest/howto/operate/index.html#team-process Endless loop with Add a new hub link ;) https://pilot-hubs.2i2c.org/en/latest/howto/operate/cmd-access.html Get access with local machine https://pilot-hubs.2i2c.org/en/latest/howto/operate/delete-hub.html
How? To where?
I guess I need access to auth0.com? https://pilot-hubs.2i2c.org/en/latest/howto/operate/manual-deploy.html
Mmm... name duplication... confusing, IMHO.
Typo
How do you know if this is happening? https://pilot-hubs.2i2c.org/en/latest/howto/operate/test-hub.html
Mmm... that worrisome, how do you handle a problematic automated deployment? https://pilot-hubs.2i2c.org/en/latest/howto/operate/grafana.html
Ask user and pass https://pilot-hubs.2i2c.org/en/latest/howto/operate/setup-new-project.html How does this work with already existing Hubs/orgs? https://pilot-hubs.2i2c.org/en/latest/topic/cluster-config.html Are all the clusters deployments inside the same Kube cluster? I think that is the case, but I need to go deeper to check it out... https://pilot-hubs.2i2c.org/en/latest/topic/defaults.html hub/values.yaml is https://github.com/2i2c-org/pilot-hubs/blob/master/hub-templates/base-hub/values.yaml https://pilot-hubs.2i2c.org/en/latest/topic/hub-templates.html
Typo
More info... https://pilot-hubs.2i2c.org/en/latest/topic/storage-layer.html
Where is this happening in the codebase?
That link is probably wrong...
|
@choldgraf and @yuvipanda those are notes I have taken last week almost without checking the repos contain. Now that I have started to look at the repos, some things are clearer than before. I still think this is probably good feedback to fix some bugs and improve some sections in the docs. You may also find some notes not as useful as they should be (because I wrote them for me first)... feel free to disregard those 😉 @yuvipanda, I will look into your PR, and try to provide useful feedback!! |
This is very helpful, @damianavila! I'm slowly responding to these one by one, either here or by fixing things :)
See https://jupyterhub.github.io/nbgitpuller/topic/automatic-merging.html for how this is handled. |
@damianavila I think I've addressed your questions around manual deployment with this PR: #360 |
@damianavila as part of clearing up the 'hub templates' documentation, I've just removed the 'ephemeral-hubs' hub template in #361. |
Thank you!! I will check your PRs ASAP 😉 |
@damianavila what do you think that we should do with this one? I feel like we should either turn this into a short and actionable list, or just close it because it's quite broad and will be hard to act upon. I think that we've made a lot of improvements to the documentation since it was opened, but am not sure what exactly has been addressed here |
I agree, most likely the stuff here was already addressed or it is no longer relevant, so closing here. |
Summary
In a recent conversation with @damianavila, he noted that it was a bit confusing to learn a few important things about the pilot hubs:
pilot-hubs
and how to access it.Acceptance criteria
Tasks to complete
The text was updated successfully, but these errors were encountered: