Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #10

Merged
merged 7 commits into from
Apr 1, 2022
Merged

Update docs #10

merged 7 commits into from
Apr 1, 2022

Conversation

GeorgianaElena
Copy link
Member

This updates the docs a bit to describe how to allow the image to be pushed to the registry for PR commits and gives more details about the workflows that we run.

Based on feedback in 2i2c-org/infrastructure#1158

we should also document the test this PR on binder feature also because I think it isn't at the moment.

@github-actions
Copy link

Binder 👈 Test this PR on Binder

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tweaks, but LGTM!

.github/workflows/build.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
GeorgianaElena and others added 3 commits April 1, 2022 18:51
Co-authored-by: Sarah Gibson <[email protected]>
Co-authored-by: Sarah Gibson <[email protected]>
@GeorgianaElena
Copy link
Member Author

Thanks @sgibson91 <3

@GeorgianaElena GeorgianaElena merged commit 75fa8a4 into 2i2c-org:main Apr 1, 2022
@GeorgianaElena GeorgianaElena deleted the upate-docs branch April 1, 2022 15:53
@damianavila
Copy link
Contributor

Super, thanks @GeorgianaElena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants