Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #222 #365

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Address #222 #365

wants to merge 3 commits into from

Conversation

cj-dimaano
Copy link
Member

No description provided.

@cj-dimaano cj-dimaano self-assigned this May 24, 2017
danielscottjames
danielscottjames requested changes Aug 26, 2017
View reviewed changes
Copy link
Member

@danielscottjames danielscottjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a noticeable regression in performance while dragging shapes - especially groups of shapes - in this PR

@slaymaker1907
Copy link
Collaborator

slaymaker1907 commented Aug 27, 2017 •
edited
Loading

Can we take a look at this and either fix and merge this or close this PR @cj-dimaano @danielscottjames ?

@cj-dimaano
Copy link
Member Author

I'll take a look at it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielscottjames danielscottjames danielscottjames requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@cj-dimaano cj-dimaano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cj-dimaano @slaymaker1907 @danielscottjames