Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux package manager #364

Merged
merged 3 commits into from
May 10, 2017
Merged

Linux package manager #364

merged 3 commits into from
May 10, 2017

Conversation

cj-dimaano
Copy link
Member

Fixes issues with package management on Linux (and potentially other OS's).

  • copying to the same source and destination is now skipped
  • subdirectories without a package.json are no longer attempted to be imported
  • removed file filter from requestOpenDirs
  • cleaned somePromises a little
  • removed uglifyjs from production build (see inline comment)

cj-dimaano added 2 commits May 7, 2017 13:54
@cj-dimaano
bugfixes
29e1487 
* removed filters from `requestOpenDirs`
* cleaned `somePromises`
* added filter to `loadPlugins` to prevent directories without `package.json` from being imported
* added check to `importPlugin` to prevent copying with the same source and destination
@cj-dimaano
fix (temporary) npm run build:prod
2f5861a
slaymaker1907
slaymaker1907 requested changes May 10, 2017
View reviewed changes
Copy link
Collaborator

@slaymaker1907 slaymaker1907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the Promise.resolve() issue.

app/services/plugin.service.ts Outdated
LOG.log(`Importing plugins from ${dir} to ${dest}.`);
await copy(dir, dest);
if (dest === dir) {
return new Promise<void>((resolve, reject) => resolve());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just return Promise.resolve()

webpack.config.js
@@ -60,14 +60,19 @@ module.exports = (env = {}) => { // pass command line arguments like `webpack ..
plugins: [
new webpack.NoEmitOnErrorsPlugin(),

/*** # 5/9/2017 ***/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we really don't even need Uglify for our application since our code is so minimal compared to the rest of electron.

@slaymaker1907 slaymaker1907 merged commit 4d12066 into master May 10, 2017
@cj-dimaano cj-dimaano mentioned this pull request May 11, 2017
Open
@cj-dimaano cj-dimaano deleted the linux-package-manager branch May 11, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaymaker1907 slaymaker1907 slaymaker1907 approved these changes

@danielscottjames danielscottjames Awaiting requested review from danielscottjames

Assignees

@danielscottjames danielscottjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cj-dimaano @slaymaker1907 @danielscottjames