Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImgBot] optimizes images #2730

Merged
merged 1 commit into from
Oct 4, 2017
Merged

[ImgBot] optimizes images #2730

merged 1 commit into from
Oct 4, 2017

Conversation

ImgBotApp
Copy link
Contributor

\img\placeholder.png (3.85%))
\notes\img\internetbs.png (8.57%))
\img\utilities\telzio.png (36.3%))

\img\placeholder.png (3.85%))
\notes\img\internetbs.png (8.57%))
\img\utilities\telzio.png (36.3%))
@mxxcon
Copy link
Contributor

mxxcon commented Sep 14, 2017

What tools do you use to optimize?
Probably want to update your website to explicitly state if you optimize images using lossless or lossy methods.
Also perhaps as an option make it optional to keep images' metadata? I can see there could be situations where that's important.

@dabutvin
Copy link

👍

ImgBot is using https://github.com/dlemstra/Magick.NET to do the lossless compression.

I definitely hear you, and we should state this explicitly on the website
imgbot/Imgbot#31

I want to roll out support for reading configuration directly from the repo with a config file
I added your suggestion about metadata there
imgbot/Imgbot#2

I really appreciate the support and the feedback on ImgBot.

Happy to help by compressing those images
If you want more prs from ImgBot here, or any of your other projects, feel free to install the GitHub app.

https://github.com/apps/ImgBot

@mxxcon
Copy link
Contributor

mxxcon commented Sep 15, 2017

Intresting that imagemagik was able to compress placeholder.png even more than all the tools in FileOptimizer

@jamcat22 jamcat22 added enhancement Issue/PR contains enhancements to the overall code of the site. update site Issue/PR updates information about a site in the repo. labels Sep 17, 2017
Copy link
Contributor

@Jawshy Jawshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jawshy Jawshy merged commit fabc8a3 into 2factorauth:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site. update site Issue/PR updates information about a site in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants