Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to create SP certificates #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanathkumarls
Copy link

Added a command which will help to create certificates for Service Provider

@pocketnest-erik
Copy link

Eager to see this merged!

@sanathkumarls
Copy link
Author

@breart this PR is out from very long time, please review. This is a must needed feature.

@breart
Copy link
Collaborator

breart commented Oct 24, 2024

@sanathkumarls it takes one bash command to generate a certificate, why do you need a Laravel command for it?

@sanathkumarls
Copy link
Author

@breart it makes developer's life easier.

@breart
Copy link
Collaborator

breart commented Oct 28, 2024

@sanathkumarls I see your point, but I'd argue the generation of certificates, their location, and rotation may be handled differently in companies — it very much depends on the setup of the environment. I see how this feature may benefit some devs, but there is not enough evidence this is going to be used by the majority. I'd rather add a command to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants