support newer/more versions of inky pHAT displays #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the auto-detect feature of the inky library also newer versions of the popular inky pHAT display are supported (for example the "InkyPHAT_SSD1608" is supported without having to specify it specificly)
|
Nice! Did you test it? I don't have an InkyPHAT and can't test it. |
|
edited first comment to include tested display and open issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the auto-detect feature of the inky library also newer versions of the popular inky pHAT display are supported (for example the "InkyPHAT_SSD1608" is supported without having to specify it specifically).
Tested it with a InkyPHAT_SSD1608 and it works fine so far. Only issue is as the resolution is a bit higher but the screens are drawn using absolute values (pixels), there is a bit of empty "border" on the very right and bottom of the display.
This might be corrected by calculating relative positions depending on the display resolution.
Note: as it is a friend of mine who build the ATM, I do not have access to the display that frequently.