Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LND verify config #51

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Add LND verify config #51

merged 2 commits into from
Jan 22, 2022

Conversation

AaronDewes
Copy link
Contributor

This adds the configuration to disable certificate verification or use a custom certificate.

@AaronDewes AaronDewes marked this pull request as ready for review January 11, 2022 10:31
@AaronDewes AaronDewes changed the title WIP: Add LND verify config Add LND verify config Jan 11, 2022
@lightisfaster
Copy link
Collaborator

lightisfaster commented Jan 22, 2022

Hi @AaronDewes, thanks for your PR! Sorry for the late comment. You set verify = on as default. I'm not sure if this can make some trouble. What do you think?

@lightisfaster lightisfaster merged commit b231178 into 21isenough:master Jan 22, 2022
@AaronDewes
Copy link
Contributor Author

Hi @AaronDewes, thanks for your PR! Sorry for the late comment. You set verify = on as default. I'm not sure if this can make some trouble. What do you think?

It could, but if it's unset (like it was before) it would default to true in the requests module, so I did the same to avoid breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants