New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitrequests: Fixed price header to have a string type instead of int … #10

Merged

jianli merged 1 commit into 21dotco:master from pooleja:onchain_payment_requests_header

Aug 17, 2016

Contributor

pooleja commented Aug 12, 2016

…due to change in requests lib

I ran into a problem with onchain buy:

$ 21 buy ... --payment-method onchain ...
May be using unconfirmed inputs to complete transaction.
Error: Header value 100000 must be of type str or bytes, not <class 'int'>

Found that the requests library made a change to fail on non string or bytes headers:
https://github.com/kennethreitz/requests/issues/3477


          Bitrequests: Fixed price header to have a string type instead of int …

1797e89

…due to change in requests lib

jianli merged commit 1797e89 into 21dotco:master

Contributor

jianli commented Aug 17, 2016

Thanks @pooleja! This patch has been deployed as part of our 3.8.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet