Support redis url secret #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trottomv
requested changes
Mar 2, 2023
{{cookiecutter.project_dirname}}/terraform/modules/kubernetes/deployment/main.tf
Outdated
Show resolved
Hide resolved
trottomv
previously approved these changes
Mar 31, 2023
trottomv
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current secret holds the
CACHE_URLvalue, as expected by thedjango-cache-urlpackage. This prevents other potential components (e.g. Celery) to access the Redis server URL, which is contained in theCACHE_URLvalue but can not easily be used as-is. Therefore I suggest storing aREDIS_URLvalue with the Redis server URL (see this PR, and then populate theCACHE_URLenvironment variable from it in the Django deployment.