Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced exemples - mtr doesn't like * in traceroute #135

Closed
CTV-2023 opened this issue Sep 24, 2021 · 1 comment
Closed

Advanced exemples - mtr doesn't like * in traceroute #135

CTV-2023 opened this issue Sep 24, 2021 · 1 comment
Labels
Milestone

Comments

@CTV-2023
Copy link

Hi,

It seems mtr doesn't parse correctly the traceroute when some routers don't answer to traceroute ("*" is returned)

2021-09-24 13:34:01,841 - vaping.plugins.fping_mtr - DEBUG: popen fping -u -C5 -p20 -e IP1 IP2 IP3 IP4 * IP6 37.49.237.49 1.1.1.1
vaping.plugins.fping_mtr popen fping -u -C5 -p20 -e IP1 IP2 IP3 IP4 * IP6 37.49.237.49 1.1.1.1 __init__.py:112
root *: Name or service not known
 fping.py:85
root failed to get data: not enough values to unpack (expected 2, got 1) fping.py:117
root IP1    : 2.48 3.54 0.47 66.47 0.48
 fping.py:85
root IP2   : 0.13 0.10 0.10 0.09 0.09
 fping.py:85
root IP3  : 0.30 0.24 0.26 0.27 0.28
 fping.py:85
root IP4 : 0.47 0.42 1.57 0.57 0.41
 fping.py:85
root IP6 : - - - - -
 fping.py:85
root 37.49.237.49   : - - - - -
 fping.py:85
root 1.1.1.1        : 3.37 3.62 3.38 3.28 12.46

I managed to make it work by modifying these lines in vaping/plugins/fping_mtr.py

Line 46 :             if host != "*" or host != "*\n":
Line 79 :             if host and host not in hosts and host != "*":
@vegu vegu added the bug label Oct 5, 2021
@vegu
Copy link
Contributor

vegu commented Oct 5, 2021

Thanks for the bug report @CTV-ByImmo

@vegu vegu closed this as completed in fe9aada Nov 8, 2021
@vegu vegu reopened this Nov 8, 2021
@vegu vegu added this to the Next release milestone Nov 8, 2021
@vegu vegu closed this as completed Nov 8, 2021
This was referenced Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants