Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zermoq plugin config validation wants both bind and connect to be set #126

Closed
vegu opened this issue Jul 30, 2021 · 0 comments · Fixed by #129
Closed

zermoq plugin config validation wants both bind and connect to be set #126

vegu opened this issue Jul 30, 2021 · 0 comments · Fixed by #129
Assignees
@vegu
Labels
bug
Milestone
1.4.3

Comments

@vegu
Copy link
Contributor

vegu commented Jul 30, 2021 •
edited
Loading

The plugin itself already checks that either bind or connect needs to be set - the config schema should set both to be optional, discovered in #125

Currently having only bind specified will result in the following validation error

confu.exceptions.ValidationError: ['plugins', 'zmq_vodka', 'connect']: missing
@vegu vegu added the bug label Jul 30, 2021
@vegu vegu self-assigned this Jul 30, 2021
@vegu vegu changed the title zermoq plugin config validaiton wants both bind and connect to be set zermoq plugin config validation wants both bind and connect to be set Jul 30, 2021
@vegu vegu mentioned this issue Jul 30, 2021
Closed
vegu added a commit that referenced this issue Aug 2, 2021
@vegu
fixes #128: module 'zmq.asyncio' has no attribute 'PUB'
c315a15 
fixes #126: zermoq plugin config validation wants both bind and connect to be set
This was referenced Aug 2, 2021
Merged
Open
@vegu vegu modified the milestone: Next Release Aug 2, 2021
@vegu vegu closed this as completed in #129 Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegu vegu

Labels
bug
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

zmq fixes 20c/vaping
1 participant
@vegu