Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBlockBreak is called once more than necessary. #36

Closed
mhmyesman opened this issue Feb 4, 2020 · 1 comment
Closed

onBlockBreak is called once more than necessary. #36

mhmyesman opened this issue Feb 4, 2020 · 1 comment
Assignees
Labels
bug A bug report fixed The issue was resolved and is available to the public good first issue An issue that would be very easy for a new contributor to try to resolve for their first

Comments

@mhmyesman
Copy link

VeinMiner calls PlayerVeinMineEvent (PVME) after onBlockBreak (oBB) is called.

VeinMiner calls oBB once for every block in the vein, disregarding the initial oBB call: VeinMiner calls oBB as if one block hasn't been broken already. This looks like a bug.

Pretty high chance I make a wrong assumption about the inner workings while using improper terminology -- forgive me.

Anyway, here is the bug how I observed it:

https://www.youtube.com/watch?v=HfpT-ZlBw_4&feature=youtu.be

Tested by sending message to player on PVME and oBB execute.

@2008Choco
Copy link
Owner

You're right. I know exactly why this is happening. I'm not sure it will have caused too many issues but this may be a potential duplication glitch if used in unison with other plugins that trigger additional block drops. Thank you for the detailed report.

@2008Choco 2008Choco added bug A bug report good first issue An issue that would be very easy for a new contributor to try to resolve for their first labels Feb 4, 2020
@2008Choco 2008Choco self-assigned this Feb 4, 2020
@2008Choco 2008Choco added the fixed The issue was resolved and is available to the public label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report fixed The issue was resolved and is available to the public good first issue An issue that would be very easy for a new contributor to try to resolve for their first
Projects
None yet
Development

No branches or pull requests

2 participants