Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the bit lengths of various IR protocols #4

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Correct the bit lengths of various IR protocols #4

merged 1 commit into from
Jan 6, 2017

Conversation

crankyoldgit
Copy link
Contributor

Disable Panasonic codes as it is called wrong.
Store data in an unsigned variable, vs a signed on, otherwise it produces bad results for high numbered codes.
Mark protocols that are > 32 bits as they won't work with values large than an unsigned long (32 bits).

Disable Panasonic codes as it is called wrong.
Store data in an unsigned variable, vs a signed on, otherwise it produces bad results for high numbered codes.
Mark protocols that are > 32 bits as they won't work with values large than an unsigned long (32 bits).
Copy link
Owner

@1technophile 1technophile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these proposals, you are letting some bits to 36 like irsend.sendCOOLIX(data, 36), why not putting them all to 32 except sony and LG?

@crankyoldgit
Copy link
Contributor Author

The protocols left at '36' are in fact protocols with 36bit datas. The ones I changed to 32bits or less are the correct sizes for those protocols. You could nobble the 36bit protocols down to 32bits but either way, the results won't be fully correct.

You probably want to parse an unsigned long long (64bit) for your value obtained by mqtt. You could then also split up that value for the correct invocation of the panasonic procedure.

Personally, I'm only using the NEC & Sony protocols, which I wanted fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants