Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LED][BREAKING] Refactor LED handling #2051

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

1technophile
Copy link
Owner

Description:

Refactor LED handling into a library
Use a task instead of relying on the loop for precise timing

BREAKING: change of macro names:

  • LED_ADDRESSABLE replace RGB_INDICATORS
  • LED_ADDRESSABLE_NUM replace ANEOPIX_IND_NUM_LEDS
  • LED_ADDRESSABLE_PIN1 replace ANEOPIX_IND_DATA_GPIO
  • LED_ADDRESSABLE_PIN2 replace ANEOPIX_IND_DATA_GPIO2
  • DEFAULT_ADJ_BRIGHTNESS replace ANEOPIX_BRIGHTNESS
  • LED_PIN and LED_PIN_ON replace previous non-RGB pin definitions and state
  • ANEOPIX_COLOR_SCHEME are now directly defined per color into platformio.ini user file

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner Author

@mrickma would you like to review this PR ?

Refactor LED handling into a library
Use a task instead of relying on the loop for precise timing
@1technophile 1technophile merged commit 435b8ca into development Sep 13, 2024
148 checks passed
@1technophile 1technophile deleted the led-refactoring branch September 13, 2024 14:56
odoral pushed a commit to odoral/OpenMQTTGateway that referenced this pull request Oct 18, 2024
Refactor LED handling into a library
Use a task instead of relying on the loop for precise timing

Co-authored-by: Florian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant