Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMP280 support, compiler directive support for oversampling #1344

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

melyux
Copy link
Contributor

@melyux melyux commented Dec 5, 2022

Description:

The BMP280 is a sister sensor to the BME280. Unlike the BME280, it doesn't measure humidity but is 33% more accurate than it for pressure. Technically, OMG already supports BMP280 with the same BME280 library (added 2018) and it worked with OMG as it is, but this updates the documentation and comments and removes the error message when a BMP280 is recognized instead of a BME280.

I also add compiler directives for temperature/humidity/pressure oversampling settings for the BME280/BMP280. It's a minor change that mirrors the existing temperature correction, and the comments for it will mention the BMP280, so I included this in this PR too. Let me know if that's ok.

Some minor spelling and grammar fixes in the comments.

I don't know how to edit/suggest things to the Compatibility website, but we could add the BMP-280 sensor I'm using to it.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner

Thanks for this, I will add the sensor to the compatibility website

@1technophile 1technophile merged commit b2666dc into 1technophile:development Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants