add wheel effect

[stevenliuyi]

Add wheel effect to resolve #325

[dhobi]

Wow, works great and looks so cool!! 👍

I really regret that I put the col/row properties in the feature config and not to the device itself. It would have saved you some work/time I guess. I'm sorry about this. I'll happily clean that after we merge your PR.

Edit: This PR will also fix #57

[1kc]

Apologies for the delay guys. Will merge and release!

[1kc]

I might change this to make it just to be 'disabled', since it does extend the menu width by quite a bit.

[1kc]

Is there a reason for keyboards having 'wheel' effects @stevenliuyi?. (https://github.com/stevenliuyi/razer-macos/blob/296abf2e350d798954e4ef43da38709b1bb114bc/src/devices/huntsman_elite.json)

It shows up as an option for my keyboard but its greyed out with 'Wheel (missing rows, col config)'

Will release for now though.

[Sharptail]

Ermm, wheel effect not showing up for razer basilisk ultimate?

[1kc]

I've made the latest release a 'pre-release'. Not exactly sure how to fix it until I have clarification from the others.

[avi-guha]

It works for me

[1kc]

It works for me

I couldn't see you screenshot could you please reupload or let me know what device it was? Thanks

[avi-guha]

It is a Blackwidow Elite

[1kc]

My bad 🤦. I thought wheel effect was for mice, makes sense now

[stevenliuyi]

My bad 🤦. I thought wheel effect was for mice, makes sense now

Yes, it's only for keyboards.

A side note: I don't have a Windows PC right now, so I can't use Synapse 3 to set the official wheel effect on my keyboard. My implementation is just based on the official Youtube video (https://www.youtube.com/watch?v=KGURYdPXJe4), so it may well not be a very accurate replica.

[stevenliuyi]

Is there a reason for keyboards having 'wheel' effects @stevenliuyi?. (https://github.com/stevenliuyi/razer-macos/blob/296abf2e350d798954e4ef43da38709b1bb114bc/src/devices/huntsman_elite.json)

It shows up as an option for my keyboard but its greyed out with 'Wheel (missing rows, col config)'

Will release for now though.

Do you still have the wheel effect greyed out with Huntsman Elite? It seems weird since the configuration is already added on https://github.com/1kc/razer-macos/blob/master/src/devices/huntsman_elite.json

[stevenliuyi]

Is there a reason for keyboards having 'wheel' effects @stevenliuyi?. (https://github.com/stevenliuyi/razer-macos/blob/296abf2e350d798954e4ef43da38709b1bb114bc/src/devices/huntsman_elite.json)
It shows up as an option for my keyboard but its greyed out with 'Wheel (missing rows, col config)'
Will release for now though.

Do you still have the wheel effect greyed out with Huntsman Elite? It seems weird since the configuration is already added on https://github.com/1kc/razer-macos/blob/master/src/devices/huntsman_elite.json

Actually, I just found out the issue. I'll fix it soon.

[1kc]

Sounds good @stevenliuyi. I think this one might be related also #342

[avi-guha]

The colouration is slightly off in one corner (pink is too light). The wheel effect follows the same colours as the wave effect but in a circular pattern if that helps. Also, the speed feature is now glitched and the wheel is frozen at a specific pattern - which is good so I can take a picture and show you the colouration.

[stevenliuyi]

Sounds good @stevenliuyi. I think this one might be related also #342

It should be fixed by #343

[1kc]

Sounds good @stevenliuyi. I think this one might be related also #342

It should be fixed by #343

That PR #343 doen't include any changes for Blackwidow V3, you think it will still fix it?

[stevenliuyi]

Sounds good @stevenliuyi. I think this one might be related also #342

It should be fixed by #343

That PR #343 doen't include any changes for Blackwidow V3, you think it will still fix it?

It seems that the configuration for Blackwidow V3 has been missing since the last release. I just added the configuration, so it should be good now.

[1kc]

Ah cheers @stevenliuyi, I will release it now.

[stevenliuyi]

@avigucci

razer-macos/src/main/animation/animationwheel.js

Line 39 in bfa3a41

matrix[i][j] = Object.values(tinycolor(`hsv(${360-angle},70%,100%)`).toRgb()).slice(0, 3);

Right now the saturation is set to be 70%. I think increasing the saturation should help. Maybe someone can test to see what would be the best value that matches the official effect? Perhaps it should be just 100%?

[1kc]

Just tested it on my huntsman, it works and is indeed very cool!

[avi-guha]

@1kc
Epic, hopefully, we'll see it in the next update. Thanks again! :)