Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 score not being passed back #70

Open
kreut opened this issue Mar 23, 2022 · 2 comments
Open

0 score not being passed back #70

kreut opened this issue Mar 23, 2022 · 2 comments

Comments

@kreut
Copy link

kreut commented Mar 23, 2022

Hi,

When a student receive a 0 and I pass the score back to Canvas, nothing actually gets passed back, making it look like it is something that needs to be graded (Bug report posted here: ).

As a possible fix, in https://github.com/IMSGlobal/lti-1-3-php-library/blob/master/src/lti/LTI_Grade.php:

$score_given = 0 + $this->score_given;
$grade_array = array_filter([
"scoreGiven" => $score_given,
"scoreMaximum" => 0 + $this->score_maximum,
"comment" => $this->comment,
"activityProgress" => $this->activity_progress,
"gradingProgress" => $this->grading_progress,
"timestamp" => $this->timestamp,
"userId" => $this->user_id,
"submissionReview" => $this->submission_review,
]);
if (!$score_given) {
$grade_array['scoreGiven'] = 0;
}

@JanHolger
Copy link

Use https://github.com/packbackbooks/lti-1-3-php-library instead, it fixes this and multiple other issues and this repo here is dead.

@kreut
Copy link
Author

kreut commented Sep 9, 2022

Thanks!

snake pushed a commit to snake/lti-1-3-php-library that referenced this issue Oct 14, 2022
…-not-found-error-msg

PODC-27 change message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants