This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Move HTML markup for "None" to macro. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting HTML in a string literal in the `currency` filter was breaking tests. It's also not ideal, since it requires using the `safe` filter, and unsafe content could potentially leak through. This patch restores the behavior of the `currency` filter and moves the markup for the "None" element to a macro.
Merged
|
Ah good lookin' out. Sorry, I should've just asked the best way to do that. Did you not check in the null macro though? I don't see it. |
|
Derp, forgot to check in the new file. Fixed. |
noahmanger
pushed a commit
that referenced
this pull request
Jun 4, 2015
Move HTML markup for "None" to macro.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting HTML in a string literal in the
currencyfilter was breakingtests. It's also not ideal, since it requires using the
safefilter,and unsafe content could potentially leak through. This patch restores
the behavior of the
currencyfilter and moves the markup for the "None"element to a macro. This also applies the new
nullmacro to other usesof the
currencyfilter.